website: Add a review step before submitting #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to hint to the user that they should reread and check what they have written. Also show numbers for ranked items rather than drag handles in the review step as the items can't be moved in that step.
Prior to this change the tests didn't handle any task types as the detection of the task type was failing.
othrayte
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
This was referenced Jan 13, 2023
Merged
fozziethebeat
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second (and last) PR for #671.
This adds a review button before the submit button. When the user clicks review the inputs become non-editable (as they are guided to read rather than edit) and there are two buttons "edit-icon" and "submit" (the skip button is not shown at this step).
I also improved the e2e test a bit with labeling support and changed it to ensure it interacts with the tasks and that it completes 10 tasks.