#668 - Add simple label #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klotske
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
|
Just a first-impression usability opinion: YES -> red, No -> green feels strange .. even though it may make sense for a "Spam?" question. Maybe we can ask a slightly different question for which Yes becomes the positive answer that could be shown on a green button? |
fozziethebeat
approved these changes
Jan 13, 2023
fozziethebeat
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #668.
Added new
LabelRadioGroupcomponent which reuses some logic fromLabelSliderGroup.Thought it would be better if component supported multiple labels if we want to simplify UX.
LabelRadioItemcontainsstatesprop to configure (specify the text, value or color) presented buttons.Here's a demo:
Blocked by #686.