Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Manim cell preview & tidy up entry points #8

Merged
merged 43 commits into from
Oct 22, 2024
Merged

Implement Manim cell preview & tidy up entry points #8

merged 43 commits into from
Oct 22, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Oct 19, 2024

Warning

This PR also includes all changes of #7 as it is a follow-up. #7 must be merged beforehand.

Closes #3.

  • This is a follow-up of Init Manim Cell detection #7 where the Manim Cell detection mechanism was initialized. Here, we implement the actual previewCode() method.
  • Furthermore, we implement a new command to preview selected text. However, note that I don't think that this is what we actually want (see review comment below).
  • The extension.ts is cleaned up by outsourcing into individual functions with docstrings.
  • We also implement the first user setting (clipboard timeout).

Parts of this PR were inspired by #5 by VladimirFokow.

showcase.manim.cell.preview.mp4

@Splines Splines changed the title Implement Manim cell preview (checkpoint_paste()) Implement Manim cell preview via checkpoint_paste() Oct 19, 2024
@Splines Splines changed the title Implement Manim cell preview via checkpoint_paste() Implement Manim cell preview & selection preview Oct 19, 2024
@Splines Splines changed the title Implement Manim cell preview & selection preview Implement Manim cell preview & tidy up entry points Oct 21, 2024
@Splines Splines marked this pull request as ready for review October 21, 2024 22:17
@Splines
Copy link
Member Author

Splines commented Oct 21, 2024

When squashing and merging this PR: in the body of the generated message, could you remove all lines up to (including) "Fix spelling mistake"? The first new commit of this branch is "Document all failed attempts to capture terminal output". It's just that GitHub somehow doesn't realize that the prior commits are already included in the base branch.

@bhoov bhoov merged commit f0b2391 into Manim-Notebook:main Oct 22, 2024
@bhoov
Copy link
Collaborator

bhoov commented Oct 22, 2024

Cell execution works as expected. This is an awesome contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't copy to clipboard
2 participants