Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphMerger: Add async versions of public methods #3976

Closed
StefanOssendorf opened this issue May 25, 2024 · 1 comment · Fixed by #3984
Closed

GraphMerger: Add async versions of public methods #3976

StefanOssendorf opened this issue May 25, 2024 · 1 comment · Fixed by #3984

Comments

@StefanOssendorf
Copy link
Contributor

StefanOssendorf commented May 25, 2024

Currently the GraphMerger only has sync merge versions. Which work perfectly fine when the BO only has sync rules.
To make the merger more async friendly it should get three new async versions of these public methods:

The new async versions must use CheckRulesAsync where the current version is using the sync method.
The current sync version must work as before.
Furthermore it should be checked where the sync merge methods are used within the framework.
If and only if the method using the merge method is already async it should be changed to the new async api.

rockfordlhotka added a commit to Freelancingonupwork/csla that referenced this issue May 31, 2024
StefanOssendorf added a commit to Freelancingonupwork/csla that referenced this issue Jun 7, 2024
StefanOssendorf added a commit to Freelancingonupwork/csla that referenced this issue Jun 10, 2024
Copy link

github-actions bot commented Dec 8, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants