Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added - GraphMerger: async versions of public methods #3984

Conversation

Freelancingonupwork
Copy link
Contributor

Added async versions of public methods in GraphMerger.cs

Fixes #3976

Copy link
Contributor

@StefanOssendorf StefanOssendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Please do not mark the conversations as resovled. Only write fixed/done as a comment and during the next review we'll either resolve it or make another comment for further improvements.

Copy link
Contributor

@StefanOssendorf StefanOssendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the method (imho) cleanup?
Otherwise I'm okay with merging :)

@StefanOssendorf
Copy link
Contributor

I don't see anything which would hinder us now. LGTM then?
@rockfordlhotka anything from your side?

@rockfordlhotka rockfordlhotka merged commit 0b5048e into MarimerLLC:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphMerger: Add async versions of public methods
3 participants