Issue126 #174
Closed
Issue126 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkirsh2
commented
Apr 24, 2023
jkirsh2
commented
- added cumulative energy delta tracking to vehicles and stations
- include energy dispensed/expended in summary report
…de energy dispensed and expended in reports.
Signed-off-by: Nicholas Reinicke <[email protected]>
Signed-off-by: Nicholas Reinicke <[email protected]>
robfitzgerald
requested changes
Apr 24, 2023
There was a problem hiding this comment.
looks great. so satisfying to see this now in the logs:
│ Total kWh Expended By Vehicles │ 676.09 kWh │
│ Total Gasoline Expended By Vehicles │ 70.24 Gal │
│ Total kWh Dispensed By Stations │ 872.03 kWh │
│ Total Gasoline Dispensed By Stations │ 7.0 Gal │
a few minor requests to wrap {}'s in Map(). thank you!
nrel/hive/model/station/station.py
Outdated
| :param delta_energy: the energy dispensed for a charge event | ||
| :return: the updated Station | ||
| """ | ||
| energy_dispensed = { |
There was a problem hiding this comment.
wrap with immutables.Map
nrel/hive/model/vehicle/vehicle.py
Outdated
| :param delta_energy: | ||
| :return: | ||
| """ | ||
| energy_expended = {k: self.energy_expended[k] + delta_energy[k] for k in self.energy.keys()} |
There was a problem hiding this comment.
wrap with immutables.Map
| :param delta_energy: | ||
| :return: | ||
| """ | ||
| energy_gained = {k: self.energy_gained[k] + delta_energy[k] for k in self.energy.keys()} |
Wrapped dictionary Signed-off-by: Joshua Hoshiko <[email protected]>
Wrapped dictionary Signed-off-by: Joshua Hoshiko <[email protected]>
|
I wrapped the dictionaries since the two volunteers working on this had to leave, but we'll need to reformat |
|
i'll take a stab at fixing this, likely pushing up a new PR with the changes + formatting |
|
Closing as this was included in #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.