Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjf/jkirsh2 issue126 formatting #179

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Conversation

robfitzgerald
Copy link
Collaborator

this PR applies the fixes requested in #174 while adhering to formatting rules (replaces #174)

@nreinicke nreinicke self-requested a review April 25, 2023 14:57
@robfitzgerald
Copy link
Collaborator Author

@nreinicke @jhoshiko i got the impression that jkirsh2 might not make it back for the formatting and if that's the case, this PR can supersede #174. i leave it to you to accept this one or wait for them on the other.

Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 perfect, thanks @robfitzgerald and thanks @jkirsh2!!

@nreinicke nreinicke merged commit a15b8ba into main Apr 25, 2023
@nreinicke nreinicke deleted the rjf/jkirsh2-issue126-formatting branch April 25, 2023 14:59
This was referenced Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants