Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: update to GIMP3-compatible command-line #95

Merged

Conversation

jayaddison
Copy link
Contributor

In particular:

  • Specify the batch script interpreter to use; GIMP3 provides multiple.

  • Use gimp-console instead of gimp to avoid a non-interactive mode issue.

This doesn't solve all compatibility problems with GIMP3 yet; we also need to resolve the removal of a gimp-image-get-active-layer API function in GIMP3.

The changes* here are intended to be backwards-compatible to GIMP2 and have been tested GIMP2.10.34 on Debian stable (bookworm), and also with GIMP3.0.0 RC2 to build the OpenGFX 7.1 sources.

*NB: the which command has been superseded by command -v since v7.1 in VCS, so a small patch adjustment is required if backporting.

 - Specify the batch script interpreter to use; GIMP3 provides
   multiple.

 - Use `gimp-console` instead of `gimp` to avoid a non-interactive
   mode issue[1].

This doesn't solve all compatibility problems with GIMP3 yet; we
also need to resolve the removal of a `gimp-image-get-active-layer`
API function in GIMP3.

The changes* here are intended to be backwards-compatible to GIMP2
and have been tested GIMP2.10.34 on Debian stable (bookworm), and
also with GIMP3.0.0 RC2 to build the OpenGFX 7.1 sources.

- [1] https://gitlab.gnome.org/GNOME/gimp/-/issues/12042

*NB: the `which` command has been superseded by `command -v` since
 v7.1 in VCS, so a small patch adjustment is required if backporting.
@frosch123 frosch123 merged commit 39c35c7 into OpenTTD:master Mar 5, 2025
3 checks passed
@jayaddison
Copy link
Contributor Author

Thanks @frosch123!

@jayaddison jayaddison deleted the issue-94/gimp3-cmdline-compatibility branch March 5, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants