Script-Fu: update to GIMP3-compatible implementation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove implicit SIOD array accesses[1] * Migrate removed `drawable` API calls to `item` equivalents * Introduce TinyScheme `vector-ref` and `vector-length` calls * Migrate[2] from `get-active-layer` to `get-selected-layers` * Call `file-png-export` (instead of `save`) with named arguments Refs: - [1] https://www.gimp.org/docs/script-fu-update.html#carempty - [2] https://samjcreations.blogspot.com/2022/08/api-gimp-29912-script-fu.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drawableAPI calls toitemequivalentsvector-refandvector-lengthcallsget-active-layertoget-selected-layersfile-png-export(instead ofsave) with named argumentsThese changes, in combination with #95 and some additional prerequisite install dependencies, allow me to use Debian
testing(trixie) to rebuild what appear naively to be very similar (but not identical) PNG output images to those shipped in Debianstable(bookworm).Despite the function call update during its declaration, the
visibleStuffvariable is no longer provided as an argument to the PNG save/export step, and I'm not sure yet whether that could imply some unintended difference-in-output (transparency, for example?). Hence opening this pull request using draft status.cc @matthijskooijman