Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Fixes & Address TODOs #267

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Workload Fixes & Address TODOs #267

merged 1 commit into from
Jan 22, 2020

Conversation

richard-cox
Copy link
Member

  • blocked on Workloads remove k8s apps #266
  • Update HelmInstall action and effect
  • Redirect to Workload page after installing
  • Require user to enter release title when deleting
  • Fix delete complete handler after changes

- Update HelmInstall action and effect
- Redirect to Workload page after installing
- Require user to enter release title when deleting
- Fix delete complete handler after changes
@richard-cox richard-cox self-assigned this Jan 17, 2020
@nwmac nwmac removed the blocked label Jan 22, 2020
@nwmac nwmac changed the base branch from release30 to master January 22, 2020 14:10
@nwmac nwmac changed the base branch from master to release30 January 22, 2020 14:10
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 0a9a602 into release30 Jan 22, 2020
@nwmac nwmac deleted the workloads-todos branch January 22, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants