Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally create kube namespace during helm install, fix kube error handling #273

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Optionally create kube namespace during helm install, fix kube error handling #273

merged 4 commits into from
Jan 23, 2020

Conversation

richard-cox
Copy link
Member

  • Blocked on Workload Fixes & Address TODOs #267
  • Allow user to select from existing namespaces or create one
  • Fix kube error handling
    • We were expecting the error to be thrown instead of wrapped in jetstream 200 and errors in response per endpoint

@richard-cox richard-cox self-assigned this Jan 21, 2020
@richard-cox richard-cox mentioned this pull request Jan 21, 2020
Merged
@nwmac nwmac changed the base branch from release30 to master January 22, 2020 14:11
@nwmac nwmac changed the base branch from master to release30 January 22, 2020 14:12
@nwmac nwmac removed the blocked label Jan 23, 2020
nwmac
nwmac approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit b88e4a7 into release30 Jan 23, 2020
@richard-cox richard-cox deleted the workloads-create-ns branch October 20, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac