Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fetch first page of maxed lists #347

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Only fetch first page of maxed lists #347

merged 1 commit into from
Mar 4, 2020

Conversation

richard-cox
Copy link
Member

@richard-cox
Ensure for maxed lists we don't make requests for pages after one
7f99c4a 
- Missing return meant we still fetched remaining pages
- This means lists are marked as busy until all pages are fetched, even though the list is displayed as maxed
@richard-cox richard-cox self-assigned this Mar 4, 2020
@richard-cox richard-cox changed the title Ensure for maxed lists we don't make requests for pages after one Only fetch first page of maxed lists Mar 4, 2020
nwmac
nwmac approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 9792290 into master Mar 4, 2020
@nwmac nwmac deleted the fix-fetch-of-maxed-list branch March 4, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac