Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fetch first page of maxed lists #4138

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Only fetch first page of maxed lists #4138

merged 1 commit into from
Mar 4, 2020

Conversation

richard-cox
Copy link
Contributor

  • Missing return meant we still fetched remaining pages
  • This means lists are marked as busy until all pages are fetched, even though the list is displayed as maxed
  • Raised by GABRIEL STOENESCU in slack.

@richard-cox
Ensure for maxed lists we don't make requests for pages after one
b8fa154 
- Missing return meant we still fetched remaining pages
- This means lists are marked as busy until all pages are fetched, even though the list is displayed as maxed
@richard-cox richard-cox self-assigned this Mar 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #4138 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4138   +/-   ##
=======================================
  Coverage   57.86%   57.86%           
=======================================
  Files         901      901           
  Lines       28912    28912           
  Branches     4090     4090           
=======================================
  Hits        16731    16731           
  Misses      12181    12181

@richard-cox richard-cox changed the title Ensure for maxed lists we don't make requests for pages after one Only fetch first page of maxed lists Mar 4, 2020
@richard-cox richard-cox mentioned this pull request Mar 4, 2020
Merged
nwmac
nwmac approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 7593040 into master Mar 4, 2020
@richard-cox richard-cox deleted the fix-fetch-of-maxed-list branch March 4, 2020 18:39
@nwmac nwmac added this to the 3.1.0 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
bug community Community Raised Issue ready for review
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @codecov-io @nwmac