Changes for fmi3 refactor in fmi.jl #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThummeTo
reviewed
Jan 11, 2023
src/FMI3/ext.jl
Outdated
| #@assert isa(dstArray[i], String) "fmi3Get!(...): Unknown data type for value reference `$(vr)` at index $(i), should be `String`, is `$(typeof(dstArray[i]))`." | ||
| dstArray[i] = fmi3GetString(inst, vr) | ||
| elseif mv.datatype.datatype == fmi3Binary | ||
| elseif tisa(mv, FMICore.mvBinary) |
There was a problem hiding this comment.
small typo, fixed in d44b18d
src/FMI3/c.jl
Outdated
| @@ -355,7 +355,7 @@ function fmi3ExitInitializationMode(c::FMU3Instance) | |||
| elseif fmi3IsScheduledExecution(c.fmu) | |||
| c.state = fmi3InstanceStateClockActivationMode | |||
| else | |||
| c.state = fmi3InstanceStateEventMode | |||
| c.state = fmi3InstanceStateContinuousTimeMode | |||
There was a problem hiding this comment.
compliant to state machine in FMI3-sepc?
There was a problem hiding this comment.
nope, artifact of a test, fixed in d44b18d
|
Please add project.toml version inc (minor change, last digit). |
|
fixed in d44b18d |
added 6 commits
January 11, 2023 13:34
…com/JoKircher/FMIImport.jl into changes-for-fmi3-refactor-in-fmi.jl
ThummeTo
added a commit
that referenced
this pull request
Mar 6, 2023
* added tests for simletypes (#75) * FMI2: Parse type and unit definitions into `modelDescription` (#74) * Changes in parsing of `modelDescription` to also consider `TypeDefinitions` and `UnitDefinitions`. Requires the definitions made in manuelbb-upb/FMICore.jl@a0c8bb2 * remove fallback for `:start` attribute if `declaredType` is defined for a `scalarVariable`. * Update docstring of `fmi2GetUnit` in src/FMI2/ext.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> --------- Co-authored-by: JoKircher <[email protected]> * Check and extend tests (#73) * update tests with new reference version * add some more tests * bump version * Changes for fmi3 refactor in fmi.jl (#70) * add modelvariables working * small changs for fmi 3 * fix of PR comments * more fixed * updates to get most of fmi3 tests to work * more changs for rework -smol * bump version * V0.15.0 Fixes and Tests for `fmi2SimpleType` and `fmi2Unit` (#77) * Simplification of Simple Type Attributes * Fixed former test issues and introduced additional tests for simple types and units. * fix condensing (#79) Co-authored-by: ThummeTo <[email protected]> * Change `fmi2Reset` logic (#78) * Change fmi2Reset logic * Trying to revert changes to libcallbackFunctions.so * Accomodate property methods for `fmi2SimpleType`. (#81) * WIP * finished refactor * minor changes --------- Co-authored-by: JoKircher <[email protected]> Co-authored-by: Manuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get the tests in FMI.jl to work these minor PR has to be merged first.