Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.2 | v0.15.0 (#75) #76

Merged
merged 11 commits into from
Mar 6, 2023
Merged

v0.14.2 | v0.15.0 (#75) #76

merged 11 commits into from
Mar 6, 2023

Conversation

ThummeTo
Copy link
Owner

No description provided.

@ThummeTo ThummeTo changed the title added tests for simletypes (#75) 0.15.0 (#75) Jan 30, 2023
manuelbb-upb and others added 3 commits January 30, 2023 09:23
* Changes in parsing of `modelDescription` to also consider
`TypeDefinitions` and `UnitDefinitions`.
Requires the definitions made in
manuelbb-upb/FMICore.jl@a0c8bb2

* remove fallback for `:start` attribute if `declaredType`
is defined for a `scalarVariable`.

* Update docstring of `fmi2GetUnit` in src/FMI2/ext.jl

Co-authored-by: JoKircher <[email protected]>

* remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl

Co-authored-by: JoKircher <[email protected]>

* remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl

Co-authored-by: JoKircher <[email protected]>

* remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl

Co-authored-by: JoKircher <[email protected]>

---------

Co-authored-by: JoKircher <[email protected]>
* update tests with new reference version

* add some more tests

* bump version
* add modelvariables working

* small changs for fmi 3

* fix of PR comments

* more fixed

* updates to get most of fmi3 tests to work

* more changs for rework -smol

* bump version
@ThummeTo ThummeTo changed the title 0.15.0 (#75) v0.14.2 | v0.15.0 (#75) Feb 13, 2023
manuelbb-upb and others added 4 commits February 13, 2023 13:30
* Simplification of Simple Type Attributes

* Fixed former test issues and introduced
additional tests for simple types and units.
Co-authored-by: ThummeTo <[email protected]>
* Change fmi2Reset logic

* Trying to revert changes to libcallbackFunctions.so
@ThummeTo
Copy link
Owner Author

ThummeTo commented Mar 2, 2023

I will push a modified version here again @manuelbb-upb and @JoKircher :

  • I deleted some code and reused the similarity between the SimpleTypes and ScalarVariables (they are sharing the same argument sub-set called fmi2RealAttributes)
  • there where some parsing functions that did almost the same as existing parsing functions, I replaced them
  • I did some renaming to better fit the existing code
  • I (temporary) removed the tests, because I removed the redundant structs
  • ...

Please feel free to review the code, If you have the time (and are interested in).

@ThummeTo
Copy link
Owner Author

ThummeTo commented Mar 2, 2023

This is WIP (tests are failing)

Copy link
Contributor

@JoKircher JoKircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! It really nice to see this package evolving!

I had no chance to test the changes of this PR yet, but I will run them locally soon!

@JoKircher
Copy link
Contributor

Tests are working as expected

@ThummeTo ThummeTo merged commit ad09157 into main Mar 6, 2023
@ThummeTo ThummeTo deleted the v0.15.0 branch March 6, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants