v0.14.2 | v0.15.0 (#75) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes in parsing of `modelDescription` to also consider `TypeDefinitions` and `UnitDefinitions`. Requires the definitions made in manuelbb-upb/FMICore.jl@a0c8bb2 * remove fallback for `:start` attribute if `declaredType` is defined for a `scalarVariable`. * Update docstring of `fmi2GetUnit` in src/FMI2/ext.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> --------- Co-authored-by: JoKircher <[email protected]>
* update tests with new reference version * add some more tests * bump version
* add modelvariables working * small changs for fmi 3 * fix of PR comments * more fixed * updates to get most of fmi3 tests to work * more changs for rework -smol * bump version
* Simplification of Simple Type Attributes * Fixed former test issues and introduced additional tests for simple types and units.
Co-authored-by: ThummeTo <[email protected]>
|
I will push a modified version here again @manuelbb-upb and @JoKircher :
Please feel free to review the code, If you have the time (and are interested in). |
|
This is WIP (tests are failing) |
JoKircher
approved these changes
Mar 6, 2023
|
Tests are working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.