-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.14.2 | v0.15.0 (#75) #76
Conversation
* Changes in parsing of `modelDescription` to also consider `TypeDefinitions` and `UnitDefinitions`. Requires the definitions made in manuelbb-upb/FMICore.jl@a0c8bb2 * remove fallback for `:start` attribute if `declaredType` is defined for a `scalarVariable`. * Update docstring of `fmi2GetUnit` in src/FMI2/ext.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> * remove `targetArray` from `parseModelDescriptionVariable` in src/FMI2/md.jl Co-authored-by: JoKircher <[email protected]> --------- Co-authored-by: JoKircher <[email protected]>
* update tests with new reference version * add some more tests * bump version
* add modelvariables working * small changs for fmi 3 * fix of PR comments * more fixed * updates to get most of fmi3 tests to work * more changs for rework -smol * bump version
* Simplification of Simple Type Attributes * Fixed former test issues and introduced additional tests for simple types and units.
Co-authored-by: ThummeTo <[email protected]>
I will push a modified version here again @manuelbb-upb and @JoKircher :
Please feel free to review the code, If you have the time (and are interested in). |
This is WIP (tests are failing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! It really nice to see this package evolving!
I had no chance to test the changes of this PR yet, but I will run them locally soon!
Tests are working as expected |
No description provided.