Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add B&A k-anonymity implementation #1402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brusshamilton
Copy link
Contributor

@brusshamilton brusshamilton commented Feb 13, 2025

@JensenPaul JensenPaul added the spec Relates to the spec label Feb 14, 2025
@JensenPaul
Copy link
Collaborator

Is this B&A specific? if so, mind mentioning "Bidding and Auction Services" in the title?

@brusshamilton brusshamilton changed the title Add k-anonymity implementation Add B&A k-anonymity implementation Feb 14, 2025
@brusshamilton
Copy link
Contributor Author

Is this B&A specific? if so, mind mentioning "Bidding and Auction Services" in the title?

Sorry, it should be fixed now.

spec.bs Outdated
:: 0
: [=generated bid/component seller=]
:: Null
: [=generated bid/number of mandatory ad components=]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about [=generated bid/target number of ad components=]? [=generated bid/number of mandatory ad components=] is only relevant when that field is not null, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct. That field is only relevant when [=generated bid/target number of ad components=] is specified. But that field is also non-null and has no default value so we have to specify something here.

My intent here is that we don't allow dropping any component ads when checking k-anonymity. That seems to be the default behavior when [=generated bid/target number of ad components=] is null, which will happen by default.

Copy link
Collaborator

@qingxinwu qingxinwu Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I didn't notice the field was non-null and had no default value, so we still need to set its value although it's irrelavant. I guess we can also give it a default value 0 in its definition instead, but no preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants