Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add B&A k-anonymity implementation #1402
base: main
Are you sure you want to change the base?
Add B&A k-anonymity implementation #1402
Changes from 2 commits
ec22c41
d881251
720663a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about [=generated bid/target number of ad components=]? [=generated bid/number of mandatory ad components=] is only relevant when that field is not null, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct. That field is only relevant when [=generated bid/target number of ad components=] is specified. But that field is also non-null and has no default value so we have to specify something here.
My intent here is that we don't allow dropping any component ads when checking k-anonymity. That seems to be the default behavior when [=generated bid/target number of ad components=] is null, which will happen by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I didn't notice the field was non-null and had no default value, so we still need to set its value although it's irrelavant. I guess we can also give it a default value 0 in its definition instead, but no preference.