Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use userid (username) as profile:name #37

Closed
wants to merge 24 commits into from
Closed

use userid (username) as profile:name #37

wants to merge 24 commits into from

Conversation

ear-dev
Copy link

@ear-dev ear-dev commented Apr 16, 2019 •
edited
Loading

Fixes WideChat/Rocket.Chat.Android#301 by disabling the change email permissions check which gets called because some users will not have an email.

  • Removes email from the profile page. I suggest we make a new story to bring email and phone number back into that page, but only as plain text and not in a disabled text box.
  • Enables the Save Changes button by default.
  • Uses the username as the "name" by default.

@ericrosenthal
use userid (username) as profile:name
d2446b7
@ericrosenthal
during accounts meld, check for user using username if the check with…
7779a3b 
… email fails
@ericrosenthal
lint errors
7a6c010
@ericrosenthal
set email during meld
3b581b5
@ericrosenthal
fix lint
51a0afb
@ericrosenthal
reorganize the set email changes into a WIDECHAT block
03b348e
@ericrosenthal
use var instead of let
5afea26
@ericrosenthal
use let properly
d3ade33
@ericrosenthal
typo
8a341b1
@ericrosenthal
add name to user if it does not exist..... backwards compatibility
bcdf627
@ericrosenthal
do not check for null
3a77457
@ericrosenthal
check for user.name and use data.userid if not set
fd2d961
@ericrosenthal
short circuit email and username validation checks to allow the Save …
8b3ce15 
…Changes button non the profile update page.
@ericrosenthal
fix lint
3311896
@ericrosenthal
comment out unreachable code... i.e. lint error
561b268
@ericrosenthal
use WIDECHAT function to always return true from the cansave() function.
44e36a1
@ericrosenthal
always return true.
9b5832b
@ericrosenthal
dummy check
c9df698
@ericrosenthal
lint fix
1e803be
@ericrosenthal
disable canSave() for profile button by sending 'enabled' by default
077d061
@ericrosenthal
remove email from profile page
dbac670
@ericrosenthal
cleanup lint
042529f
@ericrosenthal
remove email values from the profile page
1cffcd3
@ericrosenthal
disable email check upon save
4cfdca1
@jaytat0
Copy link

jaytat0 commented Apr 19, 2019

I think we should still have the Save Changes be smart as far as only being enabled when changes have happened. The save experience is pretty blind w/o it as far as whether the save happened.

@ear-dev
Copy link
Author

ear-dev commented Apr 19, 2019

We can consider that, but that would be an enhancement from upstream. In open.rocket they just show the button as enabled all the time.

@jaytat0
Copy link

jaytat0 commented Apr 19, 2019

Got it. We can write up separately if we want.

@ear-dev ear-dev closed this Apr 23, 2019
@ear-dev ear-dev deleted the ear_profile_update_bug_fix branch March 8, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaytat0 jaytat0 jaytat0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] "Save changes" is not clickable upon making profile changes in web client
3 participants
@ear-dev @jaytat0 @ericrosenthal