Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY-5259 add null checks #19

Merged
merged 1 commit into from
Sep 6, 2017
Merged

HY-5259 add null checks #19

merged 1 commit into from
Sep 6, 2017

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Sep 6, 2017

Problem

Uncaught exception trying to call a method on null reference

Solution

Add null checks and cancel the periodic timeout Timer if it hasn't already been cancelled once a result is available.

Testing

  • CI passes

@rmconsole-wf
Copy link
Contributor

rmconsole-wf commented Sep 6, 2017

General Information

Ticket(s):

Code Review(s): #19

Reviewers: patkujawa-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: font_face_observer 2.0.2
	Release Ticket(s): HY-5112, HY-5113


Last updated on Wednesday, September 06 10:53 AM CST

@aviary-wf
Copy link

Raven

Number of Findings: 0

@semveraudit-wf
Copy link

Public API Changes

No changes to the public API found for commit f71eac3

Showing results for f71eac3

Powered by semver-audit-service. Please report any problems by filing an issue.
Browse public API.

Copy link

@patkujawa-wf patkujawa-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 CR

@patkujawa-wf
Copy link

+10 CI passed

@patkujawa-wf
Copy link

Quality Review Approval: +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • All unit tests pass
  • Unit test created/updated
  • Rosie has run and reports properly the release the ticket will be included in

@Workiva/release-management-p for merge into master

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit f6d90c0 into master Sep 6, 2017
@rm-astro-wf rm-astro-wf deleted the HY-5259_uncaught_null branch September 6, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants