Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HY-5321 Turn on the strongest typing mode and make typing fixes #21

Merged
merged 2 commits into from
Sep 18, 2017
Merged

HY-5321 Turn on the strongest typing mode and make typing fixes #21

merged 2 commits into from
Sep 18, 2017

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Sep 18, 2017 •
edited by patkujawa-wf
Loading

Strongest Mode

This disables implicit casts and implicit dynamic types. This should ensure that everything works with DDC.

Testing

  • CI passes

Semver

  • No public API changes.

@rmconsole-wf
Copy link
Contributor

rmconsole-wf commented Sep 18, 2017 •
edited
Loading

General Information

Ticket(s):

Code Review(s): #21

Reviewers: patkujawa-wf, seanburke-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: font_face_observer 2.0.3
	Release Ticket(s): HY-5264, HY-5265

Last updated on Monday, September 18 05:29 PM CST

@aviary2-wf
Copy link

aviary2-wf commented Sep 18, 2017 •
edited
Loading

Raven

Number of Findings: 0

@semveraudit-wf
Copy link

semveraudit-wf commented Sep 18, 2017 •
edited
Loading

Public API Changes

No changes to the public API found for commit 6688703

Showing results for 6688703

Powered by semver-audit-service. Please report any problems by filing an issue.
Browse public API.

@robbecker-wf robbecker-wf changed the title Turn on the strongest typing mode and make typing fixes HY-5321 Turn on the strongest typing mode and make typing fixes Sep 18, 2017
seanburke-wf
seanburke-wf reviewed Sep 18, 2017
View reviewed changes
test/main.dart Outdated
ctx.font = '18px $fontName';
ctx.fillText(text, 5, 28);
Object ctx = canvas.getContext('2d');
if (ctx is CanvasRenderingContext2D) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Particularly since this is in tests, would it make sense to assert() this so we throw if it isn't true? Or explicitly cast?

Copy link
Member Author

@robbecker-wf robbecker-wf Sep 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: I suppose I could use as to explicitly cast. I can go either way on an assert. Don't mind adding it but it will generally always be CanvasRenderingContext2D but sadly getContext returns Object.

@seanburke-wf
Copy link

+1

@seanburke-wf
Copy link

+10 CI passes

@patkujawa-wf
Copy link

+10 CI passed

@seanburke-wf
Copy link

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit test created/updated
  • All unit tests pass
  • Rosie has run and reports the proper release ticket

@Workiva/release-management-p for merge into master

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 66e90ea into master Sep 18, 2017
@rmconsole2-wf rmconsole2-wf deleted the strongest_mode branch September 18, 2017 22:29
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Sep 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanburke-wf seanburke-wf seanburke-wf left review comments

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robbecker-wf @rmconsole-wf @aviary2-wf @semveraudit-wf @seanburke-wf @patkujawa-wf