Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY-5546 Add license to more files #23

Merged
merged 5 commits into from
Dec 5, 2017
Merged

Conversation

robbecker-wf
Copy link
Member

Adds the Workiva license to the top of files that did not have it already.

@rmconsole-wf
Copy link
Contributor

rmconsole-wf commented Dec 2, 2017

General Information

Ticket(s):

Code Review(s): #23

Reviewers: georgelesica-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: font_face_observer 2.0.4
	Release Ticket(s): HY-5323, HY-5324


Last updated on Monday, December 04 09:39 PM CST

@aviary-wf
Copy link

aviary-wf commented Dec 2, 2017

Raven

Number of Findings: 0

@semveraudit-wf
Copy link

semveraudit-wf commented Dec 2, 2017

Public API Changes

No changes to the public API found for commit f923cc7

Showing results for f923cc7

Powered by semver-audit-service. Please report any problems by filing an issue.
Browse public API.

@rm-astro-wf rm-astro-wf changed the title Add license to more files HY-5546 Add license to more files Dec 2, 2017
@seanburke-wf
Copy link

These dates should be 2017, rather than 2016.

@robbecker-wf
Copy link
Member Author

Oh I just matched the other date from comments in other files ... should I update ALL of them to be 2017?

@seanburke-wf
Copy link

Probably. That will be the first public release, and so the first time the copyright date is available. I'm not 100% on that; legal just had me use 2017 for pdfjs_dart.

@georgelesica-wf
Copy link

+1

@georgelesica-wf
Copy link

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated - NA - documentation
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in
  • Security review completed if necessary

Merging into master.
@Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 527d347 into master Dec 5, 2017
@rmconsole3-wf rmconsole3-wf deleted the add_license_to_more_files branch December 5, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants