Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds license info from the original JS font face observer & W3C #25

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Adds license info from the original JS font face observer & W3C #25

merged 2 commits into from
Dec 6, 2017

Conversation

robbecker-wf
Copy link
Member

Adds license info from the original JS font face observer & W3C spec page for the Font Face API

@robbecker-wf
Adds license info from the original font face observer JS repo and
13bbbc5 
license info from the Font Face API W3C spec page.
@rmconsole-wf
Copy link
Contributor

rmconsole-wf commented Dec 6, 2017 •
edited
Loading

General Information

Ticket(s): None found in title

  • Automatically create a Task ticket
  • Automatically create a Bug ticket
  • Automatically create a Improvement ticket

Code Review(s): #25

Reviewers: seanburke-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: font_face_observer 2.0.4
	Release Ticket(s): HY-5323, HY-5324

Last updated on Wednesday, December 06 11:33 AM CST

@aviary-wf
Copy link

aviary-wf commented Dec 6, 2017 •
edited by aviary2-wf
Loading

Raven

Number of Findings: 0

@semveraudit-wf
Copy link

semveraudit-wf commented Dec 6, 2017 •
edited
Loading

Public API Changes

No changes to the public API found for commit 4b8606a

Showing results for 4b8606a

Powered by semver-audit-service. Please report any problems by filing an issue.
Browse public API.

@seanburke-wf
Copy link

+1

Looks good, as per the license changes requested by legal.

@seanburke-wf
Copy link

QA +1

Comments only, no +10 needed.
@Workiva/release-management-p for merge into master

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 8216b59 into master Dec 6, 2017
@rmconsole3-wf rmconsole3-wf deleted the add_additional_license_info branch December 6, 2017 17:33
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Dec 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robbecker-wf @rmconsole-wf @aviary-wf @semveraudit-wf @seanburke-wf