Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semver audit dependency, publish publicly #27

Merged
merged 5 commits into from
Dec 6, 2017

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Dec 6, 2017

Problem

semver_audit is a workiva internal package and can't be installed externally and there's no travis.yml.

Solution

  • Remove it from pubspec.yaml.
  • Add a .travis.yml
  • update the publish_to to be correct.

@aviary2-wf
Copy link

aviary2-wf commented Dec 6, 2017

Raven

Number of Findings: 0

@codecov-wf
Copy link

codecov-wf commented Dec 6, 2017

Current coverage is 89.45% (diff: 100%)

Merging #27 into master will not change coverage

@@             master        #27   diff @@
==========================================
  Files             4          4          
  Lines           294        294          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            263        263          
  Misses           31         31          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 0dfc66b...ac13ddb

Copy link

@patkujawa-wf patkujawa-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 CR

@patkujawa-wf
Copy link

+10 as well, CI passed

@patkujawa-wf
Copy link

Quality Review Approval: +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • All unit tests pass
  • Unit test created/updated
  • Rosie has run and reports properly the release the ticket will be included in

@Workiva/release-management-p for merge into master

@rmconsole-wf rmconsole-wf merged commit 12836cb into master Dec 6, 2017
@rmconsole2-wf rmconsole2-wf deleted the remove_semver_audit branch December 6, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants