Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release over_react 1.33.1 #272

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Release over_react 1.33.1 #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
578a896
Fix ResizeSensor not shrinking properly in Chrome 73
greglittlefield-wf Mar 15, 2019
ebb8f7f
Update version meta for 1.33.1 release
greglittlefield-wf Mar 15, 2019
17281fa
Add min-height tests
greglittlefield-wf Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# OverReact Changelog

## 1.33.1

* [#272] Add `min-height: 0` to `ResizeSensor` wrapper nodes to fix issues with it not shrinking in a flexbox layout

## 1.33.0

> [Complete `1.33.0` Changeset](https://github.com/Workiva/over_react/compare/1.32.0...1.33.0)
Expand Down
4 changes: 4 additions & 0 deletions lib/src/component/resize_sensor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,13 +463,17 @@ const Map<String, dynamic> _wrapperStylesFlexChild = const {
'flex': '1 1 0%',
'msFlex': '1 1 0%',
'display': 'block',
// Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
'minHeight': '0',
};

final Map<String, dynamic> _wrapperStylesFlexContainer = {
'position': 'relative',
'flex': '1 1 0%',
'msFlex': '1 1 0%',
'display': _displayFlex,
// Fix ResizeSensor not shrinking properly: https://www.chromestatus.com/feature/6736527476391936
'minHeight': '0',
};

/// The browser-prefixed value for the CSS `display` property that enables flexbox.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: over_react
version: 1.33.0
version: 1.33.1
description: A library for building statically-typed React UI components using Dart.
homepage: https://github.com/Workiva/over_react/
authors:
Expand Down
2 changes: 2 additions & 0 deletions test/over_react/component/resize_sensor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ void main() {

expect(renderedNode.style.position, equals('relative'));
expect(renderedNode.style.display, equals('block'));
expect(renderedNode.style.minHeight, '0px');

var nodeStyleDecl = renderedNode.style;
if (browser.isInternetExplorer && browser.version.major < 11) {
Expand All @@ -157,6 +158,7 @@ void main() {
var renderedNode = renderAndGetDom((ResizeSensor()..isFlexContainer = true)());

expect(renderedNode.style.position, equals('relative'));
expect(renderedNode.style.minHeight, '0px');

var nodeStyleDecl = renderedNode.style;
if (browser.isInternetExplorer && browser.version.major < 11) {
Expand Down