-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release over_react 1.33.1 #272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Codecov Report
@@ Coverage Diff @@
## 1.33.1-release-base #272 +/- ##
====================================================
Coverage 90.27% 90.27%
====================================================
Files 36 36
Lines 1807 1807
====================================================
Hits 1631 1631
Misses 176 176 |
aaronlademann-wf
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+10
|
QA +1 @Workiva/release-management-p |
evanweible-wf
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Chrome 73 released with some changes in flexbox behavior: https://www.chromestatus.com/feature/6736527476391936
This caused ResizeSensors that were flex parents or flex children and nested in a flexbox layout to not "shrink" vertically as expected, and instead overflow their container, even with a flex-basis of 0.
How it was fixed:
Add
min-height: 0
, which is the recommended work around.Testing suggestions:
Potential areas of regression:
ResizeSensor