Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release over_react 1.33.1 #272

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Mar 15, 2019

Ultimate problem:

Chrome 73 released with some changes in flexbox behavior: https://www.chromestatus.com/feature/6736527476391936

This caused ResizeSensors that were flex parents or flex children and nested in a flexbox layout to not "shrink" vertically as expected, and instead overflow their container, even with a flex-basis of 0.

How it was fixed:

Add min-height: 0, which is the recommended work around.

Testing suggestions:

  • CI passes
  • Smoke test in layouts that use ResizeSensor

Potential areas of regression:

ResizeSensor


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@codecov-io
Copy link

Codecov Report

Merging #272 into 1.33.1-release-base will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           1.33.1-release-base     #272   +/-   ##
====================================================
  Coverage                90.27%   90.27%           
====================================================
  Files                       36       36           
  Lines                     1807     1807           
====================================================
  Hits                      1631     1631           
  Misses                     176      176

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@danchurch-wk
Copy link
Contributor

+10

  • All CI passed
  • Greg and I tested with this change and didn't find any regressions

@danchurch-wk
Copy link
Contributor

QA +1 @Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants