Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-4896, CPLAT-4897 Release over_react 2.3.1+dart2 #275

Merged
merged 3 commits into from
Mar 15, 2019
Merged

CPLAT-4896, CPLAT-4897 Release over_react 2.3.1+dart2 #275

merged 3 commits into from
Mar 15, 2019

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Mar 15, 2019 •
edited
Loading

#270 - Copy doc comments to generated accessors

Also brings #272 into the +dart2 line-of-release.

@greglittlefield-wf

@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner March 15, 2019 15:50
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf
Copy link
Contributor

+10 @Workiva/release-management-pp

@aaronlademann-wf
Copy link
Contributor Author

+1

joebingham-wk
joebingham-wk approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Contributor Author

@Workiva/release-management-pp

1 similar comment
@aaronlademann-wf
Copy link
Contributor Author

@Workiva/release-management-pp

@rmconsole4-wk rmconsole4-wk merged commit fc95425 into master Mar 15, 2019
@rmconsole4-wk rmconsole4-wk deleted the release_over_react_2.3.1+dart2 branch March 15, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebingham-wk joebingham-wk joebingham-wk approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready Type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronlademann-wf @aviary-wf @greglittlefield-wf @joebingham-wk @rmconsole-wf @rmconsole4-wk