-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SyntheticAnimationEvent / SyntheticTransitionEvent #327
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
ab1257e
to
e99946d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably add these to Line 18 of lib/over_react.dart
and possibly needs adding to
lib/src/util/handler_chain_util.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
Motivation
react-dart is adding support for
SyntheticAnimationEvent
andSyntheticTransitionEvent
, and it would be nice to have typed prop getters / setters for events likeonTransitionEnd
,onAnimationEnd
, etc. that make use of those interfaces.Changes
Add
onTransitionEnd
,onAnimationEnd
,onAnimationIteration
andonAnimationStart
toUbiquitousPropsMixin
and all the analogous changes that go along with those additions.Release Notes
Add typed props for CSS Transition and Animation DOM events.
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @kealjones-wk @joebingham-wk @sydneyjodon-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: