Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SyntheticAnimationEvent / SyntheticTransitionEvent #327

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented Aug 6, 2019

Depends on unreleased react-dart changes: Workiva/react-dart#202

Motivation

react-dart is adding support for SyntheticAnimationEvent and SyntheticTransitionEvent, and it would be nice to have typed prop getters / setters for events like onTransitionEnd, onAnimationEnd, etc. that make use of those interfaces.

Changes

Add onTransitionEnd, onAnimationEnd, onAnimationIteration and onAnimationStart to UbiquitousPropsMixin and all the analogous changes that go along with those additions.

Release Notes

Add typed props for CSS Transition and Animation DOM events.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review: @greglittlefield-wf @kealjones-wk @joebingham-wk @sydneyjodon-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably add these to Line 18 of lib/over_react.dart
and possibly needs adding to
lib/src/util/handler_chain_util.dart

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@kealjones-wk
Copy link
Contributor

@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants