Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM-53705 Release over react 2.5.0+dart1 #329

Merged
merged 3 commits into from
Aug 6, 2019
Merged

RM-53705 Release over react 2.5.0+dart1 #329

merged 3 commits into from
Aug 6, 2019

Conversation

aaronlademann-wf
Copy link
Contributor

This release incorporates the SyntheticAnimationEvent / SyntheticTransitionEvent support from #327 into the Dart 1 compatible line-of-release.

@kealjones-wk

@aaronlademann-wf
Add support for SyntheticAnimationEvent / SyntheticTransitionEvent
02ccabc 
# Conflicts:
#	lib/src/component/prop_mixins.over_react.g.dart
#	pubspec.yaml
@aaronlademann-wf
over_react 2.5.0+dart1
60ab8f1
@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner August 6, 2019 19:03
kealjones-wk
kealjones-wk approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@kealjones-wk
Copy link
Contributor

+1

@aaronlademann-wf
Copy link
Contributor Author

Travis CI is currently down.

Manual QA +1

  • I ran the steps that the CI build processes locally and confirmed that everything passed on Dart 1.24.3.

@Workiva/release-management-pp

@rmconsole5-wk rmconsole5-wk merged commit 91202ac into master_dart1 Aug 6, 2019
@rmconsole5-wk rmconsole5-wk deleted the release_over_react_2.5.0+dart1 branch August 6, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kealjones-wk kealjones-wk kealjones-wk approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready Type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronlademann-wf @aviary2-wf @kealjones-wk @rmconsole-wf @rmconsole5-wk