added positions in the treatment and diagnosis resource #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added positions array
adde positions array
New object for position (to be used in treatment and diagnosis)
ahokkonen
reviewed
Jul 19, 2021
|
|
||
| "properties": { | ||
|
|
||
| "position": { |
There was a problem hiding this comment.
Maybe this should be extracted to the separate enum file and values adjusted according to the naming convensions (aka LEGS_FRONT_LEFT -> FrontLeftLeg)?
There was a problem hiding this comment.
I agree, this would make it easier to extend in future.
There was a problem hiding this comment.
Agreed at the meeting today that I will make this change and then make a PR with it. So I will merge this PR and then make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.