Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added positions in the treatment and diagnosis resource #226

Merged
merged 3 commits into from
Jul 29, 2021
Merged

added positions in the treatment and diagnosis resource #226

merged 3 commits into from
Jul 29, 2021

Conversation

erwinspeybroeck
Copy link
Collaborator

No description provided.

adde positions array
New object for position (to be used in treatment and diagnosis)
Copy link
Contributor

@ahokkonen ahokkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about position enumeration


"properties": {

"position": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be extracted to the separate enum file and values adjusted according to the naming convensions (aka LEGS_FRONT_LEFT -> FrontLeftLeg)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this would make it easier to extend in future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed at the meeting today that I will make this change and then make a PR with it. So I will merge this PR and then make the change.

@cookeac cookeac merged commit 0caf27f into adewg:Develop Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants