Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy enumeration for icarPositionType. #230

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Jul 29, 2021

Added enums\icarPositionOnAnimalType.json, changed case of enumerated values, added some more.
Together with #226 this resolves #221.

cookeac added 3 commits July 29, 2021 19:09
Changed the case and slightly extended the positions enumeration, moving it to ..\enums\icarPositionOnAnimal.json.
This and the previous pull request it is based on resolves adewg#221.
@cookeac cookeac requested a review from alamers July 29, 2021 07:20
@cookeac cookeac linked an issue Jul 29, 2021 that may be closed by this pull request
@alamers
Copy link
Collaborator

alamers commented Jul 29, 2021

looks fine to me; I can still compile a java client:
java -jar ~/local/openapi-generator-cli-5.2.0.jar generate -g jaxrs-resteasy -i https://raw.githubusercontent.com/cookeac/ICAR/Positions-change/url-schemes/exampleUrlScheme.json && mvn package

@alamers alamers merged commit 7e9917f into adewg:Develop Jul 29, 2021
@cookeac cookeac deleted the Positions-change branch July 30, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "icarQuarterId" in the TreamentEventressources?
2 participants