Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end blob storage transfer is not working #231

Closed
7 tasks done
Tracked by #244
algattik opened this issue Apr 21, 2022 · 1 comment · Fixed by #233
Closed
7 tasks done
Tracked by #244

End-to-end blob storage transfer is not working #231

algattik opened this issue Apr 21, 2022 · 1 comment · Fixed by #233
Assignees
Labels
bug Something isn't working MVD

Comments

@algattik
Copy link

algattik commented Apr 21, 2022

Upstream eclipse-edc#1183
After #235, #236

Description

End-to-end flow for managing configuration and credentials for blob storage transfers is not working. Integration tests exist in the separate layers, but the end-to-end flow is not functional. One issue is that there are two classes named AzureBlobStoreSchema with different properties inside (#235).

While investigating the problem, it also appeared that documentation to understand how the system should work is missing.

  • How the managedResources attribute is used
  • What kinds of keys are used/transferred (shared access key vs. short-lived SAS)
  • How vaults are used

AzureStorageDataSourceFactory should call vault.getSecret(dataAddress.getKeyName()) instead of dataAddress.getProperty(AzureBlobStoreSchema.SHARED_KEY))

Acceptance Criteria

  • ADR to describe blob transfer end-to-end flow approach and details.
  • End-to-end test to verify blob data transfer (managedResources=true).
  • Test runs as part of CI.
  • Update docs.

Tasks

  • ADR on blob transfer end-to-end flow.
  • Add new end-to-end test to verify blob data transfer using DataManagement APIs
  • Update README(extensions/azure/data-plane/storage/README.md)
@algattik
Copy link
Author

Requires 4 upstream PRs to be merged

@algattik algattik added the blocked This item is blocked over the outcomes of another issue/discussion. label Apr 27, 2022
@algattik algattik removed the blocked This item is blocked over the outcomes of another issue/discussion. label Apr 29, 2022
@cpeeyush cpeeyush moved this from In Progress to In Review in Agera EDC Apr 29, 2022
@cpeeyush cpeeyush moved this from In Review to In Progress in Agera EDC Apr 29, 2022
@algattik algattik moved this from In Progress to In Review in Agera EDC May 2, 2022
@algattik algattik moved this from In Review to In Review Upstream in Agera EDC May 2, 2022
@algattik algattik moved this from In Review Upstream to Done in Agera EDC May 5, 2022
@zeier zeier closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MVD
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants