-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1183/231 system test fixture #248
Feature/1183/231 system test fixture #248
Conversation
commit 1fee857ef15696e0f4c43dd5df024ae303b0a177 Author: Alexandre Gattiker <[email protected]> Date: Thu Apr 28 12:11:03 2022 +0200 . commit 30e04b39a7422189f721fc354f198ee5056aa779 Author: Alexandre Gattiker <[email protected]> Date: Thu Apr 28 11:55:18 2022 +0200 Update build.gradle.kts
Unit Test Results 393 files + 1 393 suites +1 9m 54s ⏱️ +39s For more details on these failures, see this check. Results for commit d481cf2. ± Comparison against base commit 13cfcf8. ♻️ This comment has been updated with latest results. |
0f51167
to
8985c23
Compare
...test/java/org/eclipse/dataspaceconnector/system/tests/local/BlobTransferIntegrationTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/system/tests/local/BlobTransferIntegrationTest.java
Outdated
Show resolved
Hide resolved
system-tests/runtimes/azure-storage-transfer-consumer/build.gradle.kts
Outdated
Show resolved
Hide resolved
system-tests/runtimes/azure-storage-transfer-provider/build.gradle.kts
Outdated
Show resolved
Hide resolved
...ts/src/testFixtures/java/org/eclipse/dataspaceconnector/system/tests/utils/GatlingUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using ./gradlew clean build
I was able to build and run tests (as described in the readme).
Could not find any obvious concerns.
As I'm new to the project feel free to use my approval or to wait for another one. :-)
What this PR changes/adds
This the first of 2 PRs to add Azure transfer end-to-end test. The functionality has been split into 2 PRs to simplify the review process.
This first PR does not add any Azure transfer-specific test logic. It only restructures and improves the existing transfer test to make it extensible. The current file transfer Gatling test was split into a generic abstract class and a specific class for the File transfer logic.
The next PR will add another test subclass for Blob transfer.
Why it does that
Further notes
Also improved Gatling to perform one additional request if the transfer successful, and validate that the transfer actually succeeded.
Linked Issue(s)
Relates to #231
Checklist
no-changelog
)