Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1183/231 system test fixture #248

Merged

Conversation

algattik
Copy link

What this PR changes/adds

This the first of 2 PRs to add Azure transfer end-to-end test. The functionality has been split into 2 PRs to simplify the review process.

This first PR does not add any Azure transfer-specific test logic. It only restructures and improves the existing transfer test to make it extensible. The current file transfer Gatling test was split into a generic abstract class and a specific class for the File transfer logic.

The next PR will add another test subclass for Blob transfer.

Why it does that

Further notes

Also improved Gatling to perform one additional request if the transfer successful, and validate that the transfer actually succeeded.

Linked Issue(s)

Relates to #231

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

commit 1fee857ef15696e0f4c43dd5df024ae303b0a177
Author: Alexandre Gattiker <[email protected]>
Date:   Thu Apr 28 12:11:03 2022 +0200

    .

commit 30e04b39a7422189f721fc354f198ee5056aa779
Author: Alexandre Gattiker <[email protected]>
Date:   Thu Apr 28 11:55:18 2022 +0200

    Update build.gradle.kts
@github-actions
Copy link

github-actions bot commented Apr 28, 2022

Unit Test Results

     393 files  +  1       393 suites  +1   9m 54s ⏱️ +39s
12 141 tests +39  12 106 ✔️ +23  18 💤 ±0  17 +16 
12 202 runs  +39  12 167 ✔️ +23  18 💤 ±0  17 +16 

For more details on these failures, see this check.

Results for commit d481cf2. ± Comparison against base commit 13cfcf8.

♻️ This comment has been updated with latest results.

@algattik algattik marked this pull request as ready for review April 28, 2022 10:31
@algattik algattik force-pushed the feature/1183/231-system-test-fixture branch from 0f51167 to 8985c23 Compare April 28, 2022 11:29
Copy link

@pkirch pkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ./gradlew clean build I was able to build and run tests (as described in the readme).

Could not find any obvious concerns.

As I'm new to the project feel free to use my approval or to wait for another one. :-)

@algattik algattik merged commit d9dff0d into feature/1183-azure-e2e-test Apr 29, 2022
@algattik algattik deleted the feature/1183/231-system-test-fixture branch April 29, 2022 09:04
algattik added a commit that referenced this pull request May 5, 2022
cpeeyush pushed a commit that referenced this pull request May 5, 2022
* Feature/1183/231 system test fixture (#248)

* Feature/1183/231 azure e2e test (#251)

* Removed in-memory deps

* Update CHANGELOG.md

* Update TransferRequestFactory.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants