Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPF: Fix Azure storage copy process #1245

Merged

Conversation

algattik
Copy link
Contributor

@algattik algattik commented May 2, 2022

What this PR changes/adds

Fixes end-to-end azure storage copy process, and adds a system test to verify it.

The EDC provides the DPF with a storage access signature (rather than storage account key) for the sink. The storage access signature is passed via key vault.

In a separate PR we will provide a design decision record to document the process.

Why it does that

Further notes

Linked Issue(s)

Relates to #1183

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1245 (e9e5c8f) into main (0da15e1) will decrease coverage by 0.01%.
The diff coverage is 69.56%.

@@             Coverage Diff              @@
##               main    #1245      +/-   ##
============================================
- Coverage     59.37%   59.35%   -0.02%     
+ Complexity     2837     2835       -2     
============================================
  Files           712      712              
  Lines         15689    15689              
  Branches       1037     1037              
============================================
- Hits           9315     9312       -3     
- Misses         5954     5957       +3     
  Partials        420      420              
Impacted Files Coverage Δ
...onnector/azure/blob/core/api/BlobStoreApiImpl.java 32.65% <0.00%> (-1.39%) ⬇️
...ure/blob/core/validator/AzureStorageValidator.java 95.45% <ø> (-1.22%) ⬇️
...e/azurestorage/DataPlaneAzureStorageExtension.java 0.00% <0.00%> (ø)
...taspaceconnector/spi/types/domain/DataAddress.java 85.71% <33.33%> (ø)
...ne/azurestorage/pipeline/AzureStorageDataSink.java 90.47% <100.00%> (ø)
...estorage/pipeline/AzureStorageDataSinkFactory.java 94.59% <100.00%> (+0.65%) ⬆️
...torage/pipeline/AzureStorageDataSourceFactory.java 87.87% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da15e1...e9e5c8f. Read the comment docs.

@algattik algattik marked this pull request as ready for review May 2, 2022 13:36
@algattik algattik requested a review from paullatzelsperger May 2, 2022 13:36
@algattik algattik force-pushed the feature/1183-azure-e2e-test-2 branch from e9e5c8f to ca8706a Compare May 5, 2022 07:56
@algattik algattik requested a review from ndr-brt as a code owner May 5, 2022 07:56
@bscholtes1A bscholtes1A merged commit 8561416 into eclipse-edc:main May 5, 2022
@algattik algattik deleted the feature/1183-azure-e2e-test-2 branch June 22, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants