Samples: 04.1-file-transfer-listener: add automated test in sample 04.1 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reused from branch feature/1269-automated-tests-sample-040 * adjusted to module :samples:04.1-file-transfer-listener:integration-tests
5 tasks
…automated-test-sample-041
Codecov Report
@@ Coverage Diff @@
## feature/1535-automated-tests-sample-041 #317 +/- ##
========================================================================
Coverage 67.31% 67.31%
========================================================================
Files 771 771
Lines 16599 16599
Branches 1050 1050
========================================================================
Hits 11173 11173
Misses 4945 4945
Partials 481 481 Continue to review full report at Codecov.
|
…automated-test-sample-041
7 tasks
…automated-test-sample-041
* chore: add adoption_request.md * chore: apply feedback
…-test-400' into feature/1535/254-automated-test-sample-041
…automated-test-sample-041
…-test-400' into feature/1535/254-automated-test-sample-041 # Conflicts: # samples/04.0-file-transfer/integration-tests/src/testFixtures/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestCommon.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public static int getInt(@NotNull DescriptionRequestMessage message, String propertyName, int defaultValue) { | ||
| return ofNullable(message.getProperties()) | ||
| .map(map -> map.get(propertyName)) | ||
| .map(v -> Integer.parseInt(v.toString())) |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
+ change module name
…om:agera-edc/DataSpaceConnector into feature/1535/254-automated-test-sample-041
…ple-041' into feature/1535/254-automated-test-sample-041
ouphi
approved these changes
Jul 8, 2022
cpeeyush
reviewed
Jul 8, 2022
...ava/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferListenerSampleTest.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 8, 2022
...ava/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferListenerSampleTest.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 8, 2022
.../java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestCommon.java
Outdated
Show resolved
Hide resolved
cpeeyush
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds automated integration tests that run in CI to prevent the samples breaking due to changes in the EDC. The scope of this story is to add automated integration tests for sample 04.1.
FileTransferListenerSampleTest.java.Why it does that
Every step from sample readme is reproduced in the automated tests to reduce the risk from sample guidance diverging from actual code base.
Further notes
samples/04.1-file-transfer-listener/README.mdfixing changed references.Linked Issue(s)
Predecessor: #319
Closes #254
Checklist
no-changelog)