Samples: Refactor Sample Test 0.40 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor-sample-test-400
Codecov Report
@@ Coverage Diff @@
## feature/1535-automated-tests-sample-041 #319 +/- ##
========================================================================
Coverage 67.77% 67.77%
========================================================================
Files 759 759
Lines 16401 16401
Branches 1049 1049
========================================================================
Hits 11116 11116
Misses 4806 4806
Partials 479 479 Continue to review full report at Codecov.
|
chrislomonico
approved these changes
Jul 6, 2022
7 tasks
cpeeyush
reviewed
Jul 6, 2022
...c/test/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTest.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 6, 2022
...s/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestUtils.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 6, 2022
...s/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestUtils.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 6, 2022
...s/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestUtils.java
Outdated
Show resolved
Hide resolved
cpeeyush
reviewed
Jul 6, 2022
...s/java/org/eclipse/dataspaceconnector/extension/sample/test/FileTransferSampleTestUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
FileTransferSampleTest.javaintoFileTransferSampleTestUtils.javaby creating a test fixture.FileTransferSampleTest.javahas been moved intoFileTransferSampleTestUtils.java.FileTransferSampleTest.javainstanciates an instance ofFileTransferSampleTestUtils.javaand uses the moved code respectively.Why it does that
This PR contains a refactoring to enable the removal of duplicate code from branch feature/1535/254-automated-test-sample-041 which already contains a working integration test for sample 04.1.
Further notes
Successor of this PR: #317
Linked Issue(s)
Contributes to #254.
Checklist
no-changelog)