Fix invalid package requirement #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
fix-invalid-requirement
branch
from
f81b5a3 to
bdd3302
Compare
danielhollas
force-pushed
the
fix-invalid-requirement
branch
from
bdd3302 to
ce497a3
Compare
danielhollas
force-pushed
the
fix-invalid-requirement
branch
from
5f7ff9c to
1c59fef
Compare
danielhollas
commented
Sep 1, 2024
| @@ -26,11 +26,6 @@ repos: | |||
| hooks: | |||
| - id: yamlfmt | |||
|
|
|||
| - repo: https://github.com/asottile/setup-cfg-fmt | |||
There was a problem hiding this comment.
We've already removed this hook in other repos, it's more annoying than useful.
danielhollas
commented
Sep 1, 2024
| @@ -9,7 +9,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| steps: | |||
| - uses: softprops/[email protected] | |||
There was a problem hiding this comment.
We've don't pin other other actions to exact versions, and this just creates noise from dependabot.
This was referenced Sep 1, 2024
danielhollas
changed the title
|
Going to land this so I can cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an exception in
aiidalabpackage, see: aiidalab/aiidalab#442Alternatively, we might be able to remove this pin altogether, see last comment in #149.
In that case, the pin should be removed from AWB as well.
Corresponding fix to be more resilient in
aiidalabis aiidalab/aiidalab#444