Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid package requirement #172

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix invalid package requirement #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce497a3
Fix invalid python requirement
danielhollas Aug 12, 2024
1c59fef
Remove annoying setup.cfg formatter
danielhollas Aug 12, 2024
698c920
Unpin softprops/action-gh-release
danielhollas Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on: [push, pull_request]
jobs:

pre-commit:
# Adapted from: https://github.com/CasperWA/voila-optimade-client

runs-on: ubuntu-latest

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: softprops/action-gh-release@v2.0.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've don't pin other other actions to exact versions, and this just creates noise from dependabot.

- uses: softprops/action-gh-release@v2
name: Create release.
with:
generate_release_notes: true
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ repos:
hooks:
- id: yamlfmt

- repo: https://github.com/asottile/setup-cfg-fmt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already removed this hook in other repos, it's more annoying than useful.

rev: v2.5.0
hooks:
- id: setup-cfg-fmt

- repo: https://github.com/sirosen/check-jsonschema
rev: 0.28.6
hooks:
Expand Down
4 changes: 3 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ classifiers =
project_urls =
Bug Tracker = https://github.com/aiidalab/aiidalab-home/issues

# TODO: Remove widgetsnbextension pin
# https://github.com/aiidalab/aiidalab-home/issues/149
[options]
packages = find:
install_requires =
Expand All @@ -27,7 +29,7 @@ install_requires =
ipython~=7.0
ipywidgets~=7.6
traitlets~=5.0
widgetsnbextension<3.6.3 # Hotfix. Remove when #149 is fixed
widgetsnbextension<3.6.3
python_requires = >=3.9

[options.extras_require]
Expand Down