Add resources argument in EvalForIndexer()

[tolikzinovyev]

Summary

This way Indexer can preload most things from the database efficiently.

[tsachiherman]

the change looks fine - but I'd like to request adding some testing for the saveResourcesInCowBase method. Testing it individually or via the EvalForIndexer wrapper is up to you.
i.e. the goal is to prove that the roundCowBase here would truly initialize its state by the method. The standard cowRoundBase interface should be used to validate the correctness rather than direct access to the underlying maps.

[codecov-commenter]

Codecov Report

Merging #2952 (a95f0fa) into master (734e727) will increase coverage by 0.00%.
The diff coverage is 76.47%.

@@           Coverage Diff           @@
##           master    #2952   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files         358      358           
  Lines       57906    57889   -17     
=======================================
- Hits        27570    27563    -7     
+ Misses      27208    27201    -7     
+ Partials     3128     3125    -3     

Impacted Files	Coverage Δ
ledger/appcow.go	83.18% <0.00%> (+1.23%)	⬆️
ledger/evalIndexer.go	34.84% <50.00%> (-8.58%)	⬇️
ledger/eval.go	77.74% <100.00%> (-0.07%)	⬇️
catchup/peerSelector.go	98.95% <0.00%> (-1.05%)	⬇️
data/abi/abi_type.go	90.90% <0.00%> (-0.91%)	⬇️
network/wsPeer.go	74.37% <0.00%> (-0.84%)	⬇️
ledger/acctupdates.go	63.19% <0.00%> (-0.09%)	⬇️
network/wsNetwork.go	61.09% <0.00%> (ø)
data/transactions/verify/txn.go	44.29% <0.00%> (ø)
ledger/blockqueue.go	85.05% <0.00%> (+1.14%)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734e727...a95f0fa. Read the comment docs.

[tolikzinovyev]

I added a test. Is this what you meant?

[tsachiherman]

merged in #3019