ledger: preload resources argument in EvalForIndexer #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3019 +/- ##
========================================
Coverage 43.84% 43.85%
========================================
Files 385 385
Lines 86329 86754 +425
========================================
+ Hits 37852 38042 +190
- Misses 42515 42704 +189
- Partials 5962 6008 +46
Continue to review full report at Codecov.
|
tsachiherman
commented
Oct 8, 2021
Comment on lines
+144
to
154
| func saveResourcesInCowBase(resources EvalForIndexerResources, base *roundCowBase) { | ||
| for address, accountData := range resources.accounts { | ||
| if accountData == nil { | ||
| base.accounts[address] = basics.AccountData{} | ||
| } else { | ||
| base.accounts[address] = *accountData | ||
| } | ||
| } | ||
|
|
||
| return res | ||
| base.creators = resources.creators | ||
| } |
There was a problem hiding this comment.
This method being placed here is wrong; I'm planning on merging this functionality with the startEvaluator, but I'll be doing that after merging this code in, as other structural changes are already pending and I'd rather avoid blocking those. @tolikzinovyev @algorandskiy
tsachiherman
changed the title
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
## Summary rebase Tolik's PR on master; this PR add the ability for the indexer to preload account data so that it would be used by the evaluator. ## Test Plan Existing unit tests updated.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rebase Tolik's PR on master; this PR add the ability for the indexer to preload account data so that it would be used by the evaluator.
Test Plan
Existing unit tests updated.