testing: remove redundant checking from TestParticipationAccountsExpirationFuture #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #3042 Removes the irrelevant balance checking code
Comment on lines
54
to
59
| amt, err := sClient.GetBalance(sAccount) | ||
| a.NoError(err) | ||
| sNodeStatus, err := sClient.Status() | ||
| a.NoError(err) | ||
| seededRound := sNodeStatus.LastRound | ||
| a.Equal(amountToSendInitial, amt) |
There was a problem hiding this comment.
I think that this check need to be kept : it verifies that the above transaction truly takes place.
Comment on lines
-104
to
-105
| amt, err = sClient.GetBalance(sAccount) | ||
| a.NoError(err) |
There was a problem hiding this comment.
yes, I agree that this check can be safely removed.
Codecov Report
@@ Coverage Diff @@
## master #3043 +/- ##
=======================================
Coverage 43.65% 43.66%
=======================================
Files 391 391
Lines 86779 86779
=======================================
+ Hits 37887 37889 +2
Misses 42864 42864
+ Partials 6028 6026 -2
Continue to review full report at Codecov.
|
tsachiherman
changed the title
tsachiherman
approved these changes
Oct 12, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
…rationFuture (algorand#3043) ## Summary Reduce unneeded tests from TestParticipationAccountsExpirationFuture. Resolves algorand#3042 ## Test Plan This is a test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce unneeded tests from TestParticipationAccountsExpirationFuture.
Resolves #3042
Test Plan
This is a test