Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: remove redundant checking from TestParticipationAccountsExpirationFuture #3043

Merged
merged 2 commits into from
Oct 12, 2021
Merged

testing: remove redundant checking from TestParticipationAccountsExpirationFuture #3043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556c64a
Removed amount checks
AlgoStephenAkiki Oct 12, 2021
4aba9e6
Added back some account balance checking
AlgoStephenAkiki Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions test/e2e-go/features/participation/participationExpiration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,20 @@ func testExpirationAccounts(t *testing.T, fixture *fixtures.RestClientFixture, f

transactionFee := minTxnFee
amountToSendInitial := 5 * minAcctBalance

initialAmt, err := sClient.GetBalance(sAccount)
a.NoError(err)

fixture.SendMoneyAndWait(initialRound, amountToSendInitial, transactionFee, richAccount, sAccount, "")
amt, err := sClient.GetBalance(sAccount)

newAmt, err := sClient.GetBalance(sAccount)
a.NoError(err)

a.GreaterOrEqual(newAmt, initialAmt)

sNodeStatus, err := sClient.Status()
a.NoError(err)
seededRound := sNodeStatus.LastRound
a.Equal(amountToSendInitial, amt)

newAccountStatus, err := pClient.AccountInformation(sAccount)
a.NoError(err)
Expand Down Expand Up @@ -101,9 +108,6 @@ func testExpirationAccounts(t *testing.T, fixture *fixtures.RestClientFixture, f
// Now we want to send a transaction to the account and test that
// it was taken offline after we sent it something

amt, err = sClient.GetBalance(sAccount)
a.NoError(err)
Comment on lines -104 to -105
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree that this check can be safely removed.


_, initialRound = fixture.GetBalanceAndRound(richAccount)

blk, err := sClient.Block(initialRound)
Expand All @@ -112,11 +116,6 @@ func testExpirationAccounts(t *testing.T, fixture *fixtures.RestClientFixture, f

fixture.SendMoneyAndWait(initialRound, amountToSendInitial, transactionFee, richAccount, sAccount, "")

newAmt, err := sClient.GetBalance(sAccount)
a.NoError(err)

a.Greater(newAmt, amt)

err = fixture.WaitForRoundWithTimeout(uint64(initialRound) + 3)

newAccountStatus, err = pClient.AccountInformation(sAccount)
Expand Down