Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnsync: rollback #3177

Merged
merged 17 commits into from
Nov 3, 2021
Merged

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Nov 2, 2021

Summary

This PR rolls back the txsync, retaining only the config file changes

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #3177 (d4de9d6) into master (168cfe5) will increase coverage by 3.27%.
The diff coverage is 30.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   43.81%   47.09%   +3.27%     
==========================================
  Files         392      364      -28     
  Lines       86885    58295   -28590     
==========================================
- Hits        38073    27455   -10618     
+ Misses      42782    27654   -15128     
+ Partials     6030     3186    -2844     
Impacted Files Coverage Δ
config/localTemplate.go 50.00% <ø> (ø)
crypto/compactcert/msgp_gen.go 39.47% <0.00%> (ø)
crypto/compactcert/structs.go 100.00% <ø> (ø)
crypto/curve25519.go 61.81% <ø> (ø)
crypto/vrf.go 76.92% <ø> (ø)
data/basics/userBalance.go 27.65% <ø> (ø)
data/transactions/application.go 64.44% <ø> (ø)
data/transactions/transaction.go 31.98% <ø> (ø)
data/transactions/verify/verifiedTxnCache.go 77.55% <ø> (+5.58%) ⬆️
data/txHandler.go 0.00% <0.00%> (-9.14%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168cfe5...d4de9d6. Read the comment docs.

Move Local structure definition to localTemplate, so that changes to localTemplate are more obvious to be a change of template than a change of data.

Tested manually.
@tsachiherman tsachiherman marked this pull request as ready for review November 3, 2021 15:56
@tsachiherman tsachiherman requested review from cce and gmalouf November 3, 2021 15:56
@cce
Copy link
Contributor

cce commented Nov 3, 2021

One thing I noticed, it looks like the new version of network/latencyTracker.go from #3028 was removed in d2bbf64 but the old versions of the ping handlers from network/ping.go, network/ping_test.go, network/wsNetwork.go, and network/wsPeer.go with the old ping code are gone now too, because #3028 was not explicitly reverted on this branch.

@tsachiherman tsachiherman merged commit e10fe1c into algorand:master Nov 3, 2021
@tsachiherman tsachiherman deleted the tsachi/rollback_txnsync branch November 3, 2021 20:48
ghost pushed a commit to nicholasguo/go-algorand that referenced this pull request Dec 6, 2021
ghost pushed a commit to nicholasguo/go-algorand that referenced this pull request Jan 4, 2022
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
## Summary

This PR rolls back the txsync, retaining only the config file changes
tmc pushed a commit to tmc/go-algorand that referenced this pull request Mar 7, 2025
## Summary

This PR rolls back the txsync, retaining only the config file changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants