Display if support for Checkboxes #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendraharpalani58
changed the title
| $( this ).hide(); | ||
| } | ||
| var inputType = trigger.attr( "type" ); | ||
| if ( inputType && inputType.toLowerCase() == "checkbox" ) { |
There was a problem hiding this comment.
Do we need to accommodate radio too? Other input types?
There was a problem hiding this comment.
display_if supports all the input types which returns a value on change. I tested with radio buttons, they work.
Checkboxes, if checked, doesn't change the value of input. Rather, add another attribute "checked".
I presume other input types should work.
|
@jitendraharpalani58 can you merge master? |
|
@danielbachhuber done! |
|
Ok. Going to wait until the other ticket has been committed on VIP before merging this. |
|
Just a friendly bump - this functionality would be nice to have, as I ran into this problem again today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#241
@danielbachhuber Works for me locally. Please verify..