Display If: Match the checked value on load #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch, thanks for fixing it! |
mboynes
added a commit
that referenced
this pull request
Apr 7, 2015
Display If: Match the checked value on load
|
@mboynes Thanks for merging this! 😄 Looking forward to having this available on VIP, how long does that usually take? |
|
VIP is currently in the process of reviewing a Fieldmanager update. This may make it into that review. I expect it to be deployed this week. |
|
@bcampeau Rad. Thank you. |
|
@matthewspencer this is now live on VIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For radio buttons
trigger.val();returns the first element’s value, not the checked element’s value. This PR adds a check to see if there is a checked value when the trigger initializes.#264 has a related check for checkboxes.