-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Make sure the library works at import time #90
Conversation
@andfoy, any idea why I'm getting an Appveyor failure even with no effective changes in this PR? |
@blink1073 Let me check what's going on |
This is probably failing because of the change in conda-forge to use the MinGW toolchain to compile Winpty. |
I'm not sure what would be different here vs. the import test on conda-forge. |
conda-forge was still building the package with VS 14. Please see |
@ccordoba12 @blink1073 Sorry for being too disconnected to the latest changes. Does the m2w64 helps to solve our issues? |
Nop, it's safer to mix MinGW (Winpty) and VS 2008 (Python 2) than our previous arrangement of VS 2015 and VS 2008. |
Right you were, @ccordoba12... so we need to update the feedstock and here to use mingw? |
No, if I understood @jjhelmus correctly. We just need to compile pywintpy with the right VS compiler for the Python version it's going to use. |
Annnnd things failed in conda-forge, just as they are failing here: https://ci.appveyor.com/project/conda-forge/pywinpty-feedstock/build/1.0.38 Let's continue the discussion in conda-forge. |
I have a working solution for #59, so closing this one. |
Sorry for my wording, the right thing to say is that this is superseded by #99. |
Fixes #59.