Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Check that the library works at import time #99

Merged
merged 1 commit into from
May 24, 2018
Merged

PR: Check that the library works at import time #99

merged 1 commit into from
May 24, 2018

Conversation

ccordoba12
Copy link
Contributor

Fixes #59.

@ccordoba12 ccordoba12 added this to the v0.5.2 milestone May 23, 2018
@ccordoba12 ccordoba12 requested a review from andfoy May 23, 2018 16:27
@ccordoba12 ccordoba12 mentioned this pull request May 23, 2018
Closed
@ccordoba12
Copy link
Contributor Author

ccordoba12 commented May 24, 2018 •
edited
Loading

This puts a bit of overhead when importing on good systems, but it's working really well in my local tests on Win7 (i.e. it makes pywinpty fail to import all the time).

@ccordoba12 ccordoba12 merged commit fd7ee34 into andfoy:master May 24, 2018
@ccordoba12 ccordoba12 deleted the fix-import-win7 branch May 24, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfoy andfoy Awaiting requested review from andfoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@ccordoba12