Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on 401 responses from engine to slow down requests with invalid token #155

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Panic on 401 responses from engine to slow down requests with invalid token #155

merged 1 commit into from
Jan 19, 2023

Conversation

marioreggiori
Copy link
Contributor

To mitigate high load with unauthorized requests to the engine due to invalid API token we decided to panic on 401 HTTP responses. This causes a CrashLoopBackoff which slows down engine requests until problem is fixed.

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023 •
edited
Loading

Code Climate has analyzed commit 174f23a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marioreggiori marioreggiori changed the title Panic on 403 responses from engine to slow down requests with invalid token Panic on 401 responses from engine to slow down requests with invalid token Jan 18, 2023
@marioreggiori marioreggiori force-pushed the anxkube-727/slowdown-unauthorized-requests branch 2 times, most recently from e362dc2 to b910984 Compare January 18, 2023 10:43
LittleFox94
LittleFox94 reviewed Jan 19, 2023
View reviewed changes
@marioreggiori marioreggiori force-pushed the anxkube-727/slowdown-unauthorized-requests branch from b910984 to d80b577 Compare January 19, 2023 12:18
@LittleFox94 LittleFox94 added enhancement New feature or request patch labels Jan 19, 2023
@LittleFox94 LittleFox94 force-pushed the anxkube-727/slowdown-unauthorized-requests branch from d80b577 to 174f23a Compare January 19, 2023 13:58
@marioreggiori marioreggiori merged commit 23fed0e into main Jan 19, 2023
@marioreggiori marioreggiori deleted the anxkube-727/slowdown-unauthorized-requests branch January 23, 2023 12:55
@xrstf xrstf mentioned this pull request Feb 24, 2023
Merged
@marioreggiori marioreggiori mentioned this pull request Apr 3, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFox94 LittleFox94 LittleFox94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioreggiori @LittleFox94