Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce unauthorized/forbidden InstanceExist calls #184

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

marioreggiori
Copy link
Contributor

This PR removes panics on unauthorized/forbidden introduced in #155 and instead handles invalid configuration via debounce.

Checklist

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

@codeclimate
Copy link

codeclimate bot commented Apr 3, 2023

Code Climate has analyzed commit be25ccf and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 92.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.7% (0.2% change).

View more on Code Climate.

@marioreggiori marioreggiori force-pushed the anxkube-899/rework-unauthorized-handling branch from 9d8ed0f to 029bf4c Compare April 3, 2023 13:25
@marioreggiori marioreggiori force-pushed the anxkube-899/rework-unauthorized-handling branch from 029bf4c to be25ccf Compare April 3, 2023 13:37
@LittleFox94 LittleFox94 merged commit 9364db5 into main Apr 3, 2023
@LittleFox94 LittleFox94 deleted the anxkube-899/rework-unauthorized-handling branch April 3, 2023 15:16
@LittleFox94 LittleFox94 added enhancement New feature or request patch labels Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants