Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-logger): support standard output for file logger plugins #8681

Closed
wants to merge 11 commits into from
+111 −14
Closed

feat(file-logger): support standard output for file logger plugins #8681

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
50dafda
feat: support std output in file logger plugin
e1ijah1 Jan 13, 2023
35804e4
chore: improve the code
e1ijah1 Jan 13, 2023
bd00d46
docs: update file-logger docs
e1ijah1 Jan 15, 2023
46ad5b5
chore: improve the code
e1ijah1 Jan 15, 2023
391a3b0
chore: improve the code
e1ijah1 Jan 15, 2023
19ac1bc
chore: improve the code
e1ijah1 Jan 15, 2023
8d755b5
fix: writing to stdout instead of a special file
e1ijah1 Jan 16, 2023
249abd1
chore: improve the code
e1ijah1 Jan 17, 2023
165b7f8
chore: run apisix without daemon mode
e1ijah1 Jan 28, 2023
ed53dc2
fix: use custom config
e1ijah1 Feb 5, 2023
15b7992
make ci happy
e1ijah1 Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apisix/plugins/file-logger.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ local schema = {
path = {
type = "string"
},
log_to_std = {type = "boolean", default = false},
log_to_stdout = {type = "boolean", default = false},
include_resp_body = {type = "boolean", default = false},
include_resp_body_expr = {
type = "array",
Expand Down Expand Up @@ -118,7 +118,7 @@ end
local function write_file_data(conf, log_message)
local msg = core.json.encode(log_message)

local file, err
local file, std_out, err
if open_file_cache then
file, err = open_file_cache(conf)
else
Expand All @@ -138,10 +138,10 @@ local function write_file_data(conf, log_message)
core.log.error("failed to write file: ", conf.path, ", error info: ", err)
end

if conf.log_to_std then
local std_out, err = io_open(std_out_file, "w")
std_out:setvbuf("no")
if conf.log_to_stdout then
std_out, err = io_open(std_out_file, "w")
if std_out then
std_out:setvbuf("no")
ok, err = std_out:write(msg)
if not ok then
core.log.error("failed to write "..std_out_file..", error info: ", err)
Expand Down