Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nested_join) incorrect result of semi/anti mark join #24616

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[fix](nested_join) incorrect result of semi/anti mark join #24616

merged 1 commit into from
Sep 20, 2023

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Sep 19, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 19, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64026/221940)
Region Coverage: 27.74% (33228/119779)
Branch Coverage: 24.36% (17030/69910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7a265125b7ad2b3976450272dd3e87f2dc0881a2_7a265125b7ad2b3976450272dd3e87f2dc0881a2/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.88 seconds
stream load tsv: 596 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162148703 Bytes

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 19, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.75% (7979/21713)
Line Coverage: 28.82% (64030/222192)
Region Coverage: 27.71% (33236/119938)
Branch Coverage: 24.34% (17035/69992)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7363a21dd8b7afbfc0c500e25c138b8ba3b8e5d7_7363a21dd8b7afbfc0c500e25c138b8ba3b8e5d7/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.08 seconds
stream load tsv: 602 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162332529 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

jacktengg
jacktengg approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit 49f6eda into apache:master Sep 20, 2023
@mrhhsg mrhhsg deleted the fix_nested_join branch September 20, 2023 02:51
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
@mrhhsg
[fix](nested_join) incorrect result of semi/anti mark join (apache#24616
1fe10bf 
)
xiaokang pushed a commit that referenced this pull request Sep 20, 2023
@mrhhsg @xiaokang
[fix](nested_join) incorrect result of semi/anti mark join (#24616)
8e9fc45
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacktengg jacktengg jacktengg approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mrhhsg @doris-robot @jacktengg @morrySnow @xiaokang @yiguolei @Gabriel39